[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] qcow2: add tracepoints for qcow2_co_write_z
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] qcow2: add tracepoints for qcow2_co_write_zeroes |
Date: |
Mon, 16 May 2016 10:32:28 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/14/2016 06:01 AM, Denis V. Lunev wrote:
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 5 +++++
> trace-events | 2 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 9a54bbd..97bf870 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -2435,6 +2435,9 @@ static coroutine_fn int
> qcow2_co_write_zeroes(BlockDriverState *bs,
> int head = sector_num % s->cluster_sectors;
> int tail = (sector_num + nb_sectors) % s->cluster_sectors;
>
> + trace_qcow2_write_zeroes_start_req(qemu_coroutine_self(), sector_num,
> + nb_sectors);
> +
Can we trace these by byte locations rather than by sector count?
Ultimately, I think we want to move write_zeroes to a byte-based
interface, even if we still assert internally that it is at least
sector-aligned.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io, (continued)
- [Qemu-devel] [PATCH 2/6] block: split write_zeroes always, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 3/6] qcow2: simplify logic in qcow2_co_write_zeroes, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 6/6] qcow2: merge is_zero_cluster helpers into qcow2_co_write_zeroes, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 5/6] qcow2: fix condition in is_zero_cluster, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 4/6] qcow2: add tracepoints for qcow2_co_write_zeroes, Denis V. Lunev, 2016/05/14
- Re: [Qemu-devel] [PATCH 4/6] qcow2: add tracepoints for qcow2_co_write_zeroes,
Eric Blake <=