Re: [Qemu-devel] [PATCH CFT v3 00/50] NEED_CPU_H / cpu.h / hw/hw.h cleanups

[Peter Maydell]

On 16 May 2016 at 17:53, Peter Maydell <address@hidden> wrote:
> ppc64 (this is the ppc64be host in the GCC compile farm if
> you have an account there):
>
> /home/pm215/qemu/hw/intc/xics_kvm.c: In function ‘icp_get_kvm_state’:
> /home/pm215/qemu/hw/intc/xics_kvm.c:54:12: error: variable ‘reg’ has
> initializer but incomplete type
>      struct kvm_one_reg reg = {
>             ^
> /home/pm215/qemu/hw/intc/xics_kvm.c:55:9: error: unknown field ‘id’
> specified in initializer
>          .id = KVM_REG_PPC_ICP_STATE,
>          ^
> /home/pm215/qemu/hw/intc/xics_kvm.c:55:15: error:
> ‘KVM_REG_PPC_ICP_STATE’ undeclared (first use in this function)
>          .id = KVM_REG_PPC_ICP_STATE,
>                ^
>
> etc -- looks like missing a kvm include somewhere.

I logged in by hand to do a -k build; the only other error was:
/home/pm215/qemu/hw/ppc/spapr_pci.c: In function ‘spapr_phb_realize’:
/home/pm215/qemu/hw/ppc/spapr_pci.c:1426:5: error: implicit
declaration of function ‘kvm_enabled’
[-Werror=implicit-function-declaration]
     if (kvm_enabled()) {
     ^
/home/pm215/qemu/hw/ppc/spapr_pci.c:1426:5: error: nested extern
declaration of ‘kvm_enabled’ [-Werror=nested-externs]

bonus w32 build failure:

  CC    trace/control.o
In file included from
/home/petmay01/linaro/qemu-for-merges/include/block/aio.h:22:0,
                 from
/home/petmay01/linaro/qemu-for-merges/include/block/block.h:4,
                 from
/home/petmay01/linaro/qemu-for-merges/include/monitor/monitor.h:6,
                 from /home/petmay01/linaro/qemu-for-merges/trace/control.c:23:
/home/petmay01/linaro/qemu-for-merges/include/qemu/timer.h: In
function ‘get_clock’:
/home/petmay01/linaro/qemu-for-merges/include/qemu/timer.h:818:5:
error: implicit declaration of function ‘muldiv64’
[-Werror=implicit-function-declaration]
     return muldiv64(ti.QuadPart, NANOSECONDS_PER_SECOND, clock_freq);
     ^
/home/petmay01/linaro/qemu-for-merges/include/qemu/timer.h:818:5:
error: nested extern declaration of ‘muldiv64’
[-Werror=nested-externs]
In file included from
/home/petmay01/linaro/qemu-for-merges/include/qemu/bitops.h:16:0,
                 from
/home/petmay01/linaro/qemu-for-merges/include/qemu/hbitmap.h:15,
                 from
/home/petmay01/linaro/qemu-for-merges/include/block/dirty-bitmap.h:5,
                 from
/home/petmay01/linaro/qemu-for-merges/include/block/block.h:9,
                 from
/home/petmay01/linaro/qemu-for-merges/include/monitor/monitor.h:6,
                 from /home/petmay01/linaro/qemu-for-merges/trace/control.c:23:
/home/petmay01/linaro/qemu-for-merges/include/qemu/host-utils.h: At top level:
/home/petmay01/linaro/qemu-for-merges/include/qemu/host-utils.h:84:24:
error: conflicting types for ‘muldiv64’
 static inline uint64_t muldiv64(uint64_t a, uint32_t b, uint32_t c)
                        ^
In file included from
/home/petmay01/linaro/qemu-for-merges/include/block/aio.h:22:0,
                 from
/home/petmay01/linaro/qemu-for-merges/include/block/block.h:4,
                 from
/home/petmay01/linaro/qemu-for-merges/include/monitor/monitor.h:6,
                 from /home/petmay01/linaro/qemu-for-merges/trace/control.c:23:
/home/petmay01/linaro/qemu-for-merges/include/qemu/timer.h:818:12:
note: previous implicit declaration of ‘muldiv64’ was here
     return muldiv64(ti.QuadPart, NANOSECONDS_PER_SECOND, clock_freq);
            ^
cc1: all warnings being treated as errors

thanks
-- PMM