[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cpus.c: Use pthread_sigmask() rather than sigpr
Re: [Qemu-devel] [PATCH] cpus.c: Use pthread_sigmask() rather than sigprocmask()
Mon, 16 May 2016 18:37:21 +0100
On 16 May 2016 at 18:33, Peter Maydell <address@hidden> wrote:
> On Linux, sigprocmask() and pthread_sigmask() are in practice the
> same thing (they only set the signal mask for the calling thread),
> but the documentation states that the behaviour of sigprocmask() in a
> multithreaded process is undefined. Use pthread_sigmask() instead
> (which is what we do in almost all places in QEMU that alter the
> signal mask already).
The only other sigprocmask() uses are in linux-user, apart from
a couple in net/tap.c, where they're used as part of forking and
spawning the helper process. I suspect this should be using
qemu_fork() instead of doing it all by hand, wrongly...