[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v4 7/9] block: Assert !bs->refcnt in bdrv_close()

From: Max Reitz
Subject: [Qemu-devel] [PATCH v4 7/9] block: Assert !bs->refcnt in bdrv_close()
Date: Tue, 17 May 2016 16:41:32 +0200

The only caller of bdrv_close() left is bdrv_delete(). We may as well
assert that, in a way (there are some things in bdrv_close() that make
more sense under that assumption, such as the call to
bdrv_release_all_dirty_bitmaps() which in turn assumes that no frozen
bitmaps are attached to the BDS).

In addition, being called only in bdrv_delete() means that we can drop
bdrv_close()'s forward declaration at the top of block.c.

Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
 block.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block.c b/block.c
index 5693787..7efc61c 100644
--- a/block.c
+++ b/block.c
@@ -74,8 +74,6 @@ static BlockDriverState *bdrv_open_inherit(const char 
 /* If non-zero, use only whitelisted block drivers */
 static int use_bdrv_whitelist;
-static void bdrv_close(BlockDriverState *bs);
 #ifdef _WIN32
 static int is_windows_drive_prefix(const char *filename)
@@ -2110,6 +2108,7 @@ static void bdrv_close(BlockDriverState *bs)
     BdrvAioNotifier *ban, *ban_next;
+    assert(!bs->refcnt);
     bdrv_drained_begin(bs); /* complete I/O */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]