Re: [Qemu-devel] [PATCH 20/50] target-xtensa: make cpu-qom.h not target specific

[Paolo Bonzini]

On 17/05/2016 16:24, Max Filippov wrote:
>> > Make XtensaCPU an opaque type within cpu-qom.h, and move all definitions
>> > of private methods, as well as all type definitions that require knowledge
>> > of the layout to cpu.h.  Conversely, move all definitions needed to
>> > define a class to cpu-qom.h.  This helps making files independent of
>> > NEED_CPU_H if they only need to pass around CPU pointers.
> XtensaCPUClass doesn't need definition of XtensaConfig that pulled a lot
> of related structures, macros and enums from cpu.h. Mere
>   typedef struct XtensaConfig XtensaConfig;
> above the XtensaCPUClass could be enough. How about the following?

Fine, I'll test your patch and replace mine with it.

Paolo