[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 20/50] target-xtensa: make cpu-qom.h not target

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 20/50] target-xtensa: make cpu-qom.h not target specific
Date: Tue, 17 May 2016 18:42:09 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

On 17/05/2016 16:24, Max Filippov wrote:
>> > Make XtensaCPU an opaque type within cpu-qom.h, and move all definitions
>> > of private methods, as well as all type definitions that require knowledge
>> > of the layout to cpu.h.  Conversely, move all definitions needed to
>> > define a class to cpu-qom.h.  This helps making files independent of
>> > NEED_CPU_H if they only need to pass around CPU pointers.
> XtensaCPUClass doesn't need definition of XtensaConfig that pulled a lot
> of related structures, macros and enums from cpu.h. Mere
>   typedef struct XtensaConfig XtensaConfig;
> above the XtensaCPUClass could be enough. How about the following?

Fine, I'll test your patch and replace mine with it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]