[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/18] exec: add tb_hash_func5, derived from
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH v5 08/18] exec: add tb_hash_func5, derived from xxhash |
Date: |
Tue, 17 May 2016 15:48:34 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, May 17, 2016 at 20:22:52 +0300, Sergey Fedorov wrote:
> On 14/05/16 06:34, Emilio G. Cota wrote:
(snip)
> > +static inline
> > +uint32_t tb_hash_func5(uint64_t a0, uint64_t b0, uint32_t e)
> > +{
> > + uint32_t v1 = TB_HASH_XX_SEED + PRIME32_1 + PRIME32_2;
> > + uint32_t v2 = TB_HASH_XX_SEED + PRIME32_2;
> > + uint32_t v3 = TB_HASH_XX_SEED + 0;
> > + uint32_t v4 = TB_HASH_XX_SEED - PRIME32_1;
> > + uint32_t a = a0 >> 31 >> 1;
>
> I'm wondering if there's something special forcing us to make ">> 31
> >>1" instead of just ">> 32" on uint64_t?
Not really; it's perfectly fine to do >> 32 since both a0 and b0
are u64's.
I've changed it in my tree, thanks.
Emilio
- Re: [Qemu-devel] [PATCH v5 04/18] include/processor.h: define cpu_relax(), (continued)
- [Qemu-devel] [PATCH v5 06/18] atomics: add atomic_read_acquire and atomic_set_release, Emilio G. Cota, 2016/05/13
- [Qemu-devel] [PATCH v5 13/18] qht: support parallel writes, Emilio G. Cota, 2016/05/13
- [Qemu-devel] [PATCH v5 10/18] qdist: add module to represent frequency distributions of data, Emilio G. Cota, 2016/05/13
- [Qemu-devel] [PATCH v5 08/18] exec: add tb_hash_func5, derived from xxhash, Emilio G. Cota, 2016/05/13
- [Qemu-devel] [PATCH v5 16/18] qht: add test-qht-par to invoke qht-bench from 'check' target, Emilio G. Cota, 2016/05/13
- [Qemu-devel] [PATCH v5 17/18] tb hash: track translated blocks with qht, Emilio G. Cota, 2016/05/13
- [Qemu-devel] [PATCH v5 15/18] qht: add qht-bench, a performance benchmark, Emilio G. Cota, 2016/05/13
- [Qemu-devel] [PATCH v5 14/18] qht: add test program, Emilio G. Cota, 2016/05/13
- [Qemu-devel] [PATCH v5 09/18] tb hash: hash phys_pc, pc, and flags with xxhash, Emilio G. Cota, 2016/05/13
- [Qemu-devel] [PATCH v5 11/18] qdist: add test program, Emilio G. Cota, 2016/05/13
- [Qemu-devel] [PATCH v5 12/18] qht: QEMU's fast, resizable and scalable Hash Table, Emilio G. Cota, 2016/05/13