Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Some more write_zeroes tests

[Kevin Wolf]

Am 17.05.2016 um 22:35 hat Eric Blake geschrieben:
> No test of crossing a cluster boundary at this point?  I would probably do:
> 
> $QEMU_IO -c "write -z 27k 2k" "$TEST_IMG" | _filter_qemu_io
> 
> then check that the map shows an allocation starting at 24k for 8192 bytes

> What you have looks fine, but again, I'd consider also testing a
> sub-cluster size 'write -z' that spans a cluster boundary, including the
> case where it is overwriting data from the backing file.

Okay, I'll put some more time into this test case. What we're testing
here is a source for corruption bugs, so it's probably worth doing it
right.

Kevin

pgp1hcy3MWOHP.pgp
Description: PGP signature