Re: [Qemu-devel] [PATCH 41/50] s390x: move stuff out of cpu.h

[Cornelia Huck]

On Thu, 19 May 2016 12:32:05 +0200
Paolo Bonzini <address@hidden> wrote:

> On 19/05/2016 12:17, Cornelia Huck wrote:
> > On Mon, 16 May 2016 17:36:13 +0200
> > Paolo Bonzini <address@hidden> wrote:
> > 
> > Maybe mention which stuff was moved why ;)
> 
> Right:
> 
> ----
> Move cpu_inject_* to the only C file where they are used.
> 
> Move ioinst.h declarations that need S390CPU to cpu.h, to make
> ioinst.h independent of cpu.h.
> 
> Move channel declarations that only need SubchDev from cpu.h
> to css.h, to make more channel users independent of cpu.h.

Sounds good.

> ----
> 
> >> -#include "css.h"
> >> +#include <hw/s390x/s390_flic.h>
> > 
> > Wonder why we didn't need that one before?
> 
> It's not needed, hw/s390x/css.h includes it.  But this file uses
> AdapterRoutes, so I added it explicitly.

Thanks, makes sense.

> 
> >> +#include <hw/s390x/css.h>
> >>
> >>  #define VIRTUAL_CSSID 0xfe