[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] trace: enable tracing in qemu-io
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] trace: enable tracing in qemu-io |
Date: |
Thu, 19 May 2016 17:23:46 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/17/2016 02:20 AM, Denis V. Lunev wrote:
> Moving trace_init_backends() into trace_opt_parse() is not possible. This
> should be called after daemonize() in vl.c.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
> qemu-io.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
Please add documentation of the new syntax of the -T option, so that it
shows up in --help output (I'd ask for it in the man page, too, except
qemu-io doesn't seem to have one).
With just this patch applied, I still see in 'qemu-io --help':
-T, --trace FILE enable trace events listed in the given file
which doesn't tell me how to turn on particular trace events, vs. the
more useful details in 'qemu-system-x86_64 --help':
-trace [[enable=]<pattern>][,events=<file>][,file=<file>]
specify tracing options
It is okay to just say "see qemu(1) man page for full description" (the
way we did for the --object option), rather than copy-and-paste a
paragraph that might go out of sync over time.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/3] trace: enable tracing in qemu-io/qemu-nbd, Denis V. Lunev, 2016/05/17
- [Qemu-devel] [PATCH 2/3] trace: enable tracing in qemu-io, Denis V. Lunev, 2016/05/17
- Re: [Qemu-devel] [PATCH 2/3] trace: enable tracing in qemu-io,
Eric Blake <=
- [Qemu-devel] [PATCH 1/3] trace: move qemu_trace_opts to trace/control.c, Denis V. Lunev, 2016/05/17
- [Qemu-devel] [PATCH 3/3] trace: enable tracing in qemu-nbd, Denis V. Lunev, 2016/05/17
- Re: [Qemu-devel] [PATCH 0/3] trace: enable tracing in qemu-io/qemu-nbd, Paolo Bonzini, 2016/05/17
- Re: [Qemu-devel] [PATCH 0/3] trace: enable tracing in qemu-io/qemu-nbd, Stefan Hajnoczi, 2016/05/27