[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/4] QOM'ify hw/char devices

From: xiaoqiang zhao
Subject: Re: [Qemu-devel] [PATCH v4 0/4] QOM'ify hw/char devices
Date: Fri, 20 May 2016 20:27:41 +0800

> 在 2016年5月20日,19:08,Paolo Bonzini <address@hidden> 写道:
>> On 20/05/2016 04:41, xiaoqiang zhao wrote:
>> It seems that qemu_char_get_next_serial()  call the qemu_chr_fe_claim,
>> which is also called by
>> qdev_prop_set_chr ! This cause chr->avail_connectinos less than 1. as
>> the error message said:
>> "it's in use".
>> A stright fix is to call the qemu_chr_fe_release after
>> qemu_char_get_next_serial and the call the
>> qdev_prop_set_chr, the error is gone! I have test with your test cases
>> and it works.
>> Or another way, can we modify qemu_char_get_next_serial and just skip
>> the call of qemu_chr_fe_claim?
> You can replace calls to qemu_char_get_next_serial() with direct access
> to serial_hds[0], serial_hds[1], etc.  Please do this for etrax_ser too.
> Paolo

OK,fix in the next version!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]