[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/9] virtio-blk: multiqueue batch notify
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 5/9] virtio-blk: multiqueue batch notify |
Date: |
Sat, 21 May 2016 18:02:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 21/05/2016 01:40, Stefan Hajnoczi wrote:
> + while ((i = find_next_bit(s->batch_notify_vqs, nvqs, i)) < nvqs) {
> + VirtQueue *vq = virtio_get_queue(vdev, i);
> +
> + bitmap_clear(s->batch_notify_vqs, i, 1);
clear_bit?
> + if (s->dataplane_started && !s->dataplane_disabled) {
> + virtio_blk_data_plane_notify(s->dataplane, vq);
> + } else {
> + virtio_notify(vdev, vq);
> + }
The find_next_bit loop is not very efficient and could use something
similar to commit 41074f3 ("omap_intc: convert ffs(3) to ctz32() in
omap_inth_sir_update()", 2015-04-28). But it can be improved later.
Thanks,
Paolo
- [Qemu-devel] [PATCH 0/9] virtio-blk: multiqueue support, Stefan Hajnoczi, 2016/05/20
- [Qemu-devel] [PATCH 4/9] virtio-blk: add VirtIOBlockConf->num_queues, Stefan Hajnoczi, 2016/05/20
- [Qemu-devel] [PATCH 6/9] vmstate: add VMSTATE_VARRAY_UINT32_ALLOC, Stefan Hajnoczi, 2016/05/20
- [Qemu-devel] [PATCH 7/9] virtio-blk: live migrate s->rq with multiqueue, Stefan Hajnoczi, 2016/05/20
- [Qemu-devel] [PATCH 9/9] virtio-blk: add num-queues device property, Stefan Hajnoczi, 2016/05/20