[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 10/15] target-i386: Call cpu_exec_init() on realize

From: Eduardo Habkost
Subject: [Qemu-devel] [PULL 10/15] target-i386: Call cpu_exec_init() on realize
Date: Mon, 23 May 2016 16:24:22 -0300

QOM instance_init functions are not supposed to have any side-effects,
as new objects may be created at any moment for querying property
information (see qmp_device_list_properties()).

Calling cpu_exec_init() also affects QEMU's ability to handle errors
during CPU creation, as some actions done by cpu_exec_init() can't be

Move cpu_exec_init() call to realize so a simple object_new() won't
trigger it, and so that it is called after some basic validation of CPU

Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
 target-i386/cpu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 9ac2e59..895a386 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2902,6 +2902,8 @@ static void x86_cpu_realizefn(DeviceState *dev, Error 
+    cpu_exec_init(cs, &error_abort);
     if (tcg_enabled()) {
@@ -3094,7 +3096,6 @@ static void x86_cpu_initfn(Object *obj)
     FeatureWord w;
     cs->env_ptr = env;
-    cpu_exec_init(cs, &error_abort);
     object_property_add(obj, "family", "int",

reply via email to

[Prev in Thread] Current Thread [Next in Thread]