[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/2] backup: Fail early if cannot determine c

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2 1/2] backup: Fail early if cannot determine cluster size
Date: Tue, 24 May 2016 09:45:29 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 19.05.2016 um 03:25 hat Fam Zheng geschrieben:
> Otherwise the job is orphaned and block_job_cancel_sync in
> bdrv_close_all() when quitting will trigger assertion failure.
> Cc: address@hidden
> Reviewed-by: John Snow <address@hidden>
> Reviewed-by: Jeff Cody <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>

Instead of moving the code around, wouldn't it have been easier to just
add the missing block_job_unref() call? That would also seem safer with
respect to future changes in the code that might reintroduce new error
conditions after block_job_create() and resurrect this bug.

That said, the patch looks correct, so if you don't want to change it:

Reviewed-by: Kevin Wolf <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]