[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode
Date: Tue, 24 May 2016 21:25:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

On 24/05/2016 19:47, Laszlo Ersek wrote:
> Which I think satisfies (a->mr == b->mr), but falsifies (a->romd_mode
> == b->romd_mode).
> In effect, the patch seems to allow merging and equality between
> FlatRange objects when they only differ in romd_mode, and that's
> wrong.
> Given that the cover letter for this series says "memory: Dead code
> removals", I'm requesting that this patch be simply reverted.
> Drew and myself bisected this independently, in parallel. The bug was
> originally reported by Drew, so I think on the revert commit, the
> Reported-by should belong to him. Beyond the bisection, Drew also
> tested the exact revert, and it restores functionality. For which
> reason, I'm proposing, for the revert patch:
> Reported-by: Drew Jones <address@hidden>
> Tested-by: Drew Jones <address@hidden>
> If my analysis above is correct, then I wouldn't mind taking credit
> for it, something like:
> Analyzed-by: Laszlo Ersek <address@hidden>

That makes a lot of sense.  Revert on the way.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]