[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode |
|
Date: |
Wed, 25 May 2016 09:29:03 +0800 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, 05/24 19:47, Laszlo Ersek wrote:
> Which I think satisfies (a->mr == b->mr), but falsifies (a->romd_mode ==
> b->romd_mode).
>
> In effect, the patch seems to allow merging and equality between FlatRange
> objects when they only differ in romd_mode, and that's wrong.
>
> Given that the cover letter for this series says "memory: Dead code
> removals", I'm requesting that this patch be simply reverted.
Yes, it is a mistake, let's revert it. Thanks a lot for the analysis!
Fam