[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 for-2.7 24/28] migration: don't use an array

From: Amit Shah
Subject: Re: [Qemu-devel] [PATCH v6 for-2.7 24/28] migration: don't use an array for storing migrate parameters
Date: Wed, 25 May 2016 16:40:57 +0530

On (Wed) 27 Apr 2016 [11:05:14], Daniel P. Berrange wrote:
> The MigrateState struct uses an array for storing migration
> parameters. This presumes that all future parameters will
> be integers too, which is not going to be the case. There
> is no functional reason why an array is used, if anything
> it makes the code less clear. The QAPI schema already
> defines a struct - MigrationParameters - capable of storing
> all the individual parameters, so just use that instead of
> an array.
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>


This will get conflicts with current master after the autoconverge
patches dropping the x-.

I can handle these conflicts during merge if no respins are required.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]