Re: [Qemu-devel] [PATCH v2 03/14] block: Default to enabled write cache in blk_new()

[Alberto Garcia]

On Tue 24 May 2016 03:47:23 PM CEST, Kevin Wolf wrote:
> The existing users of the function are:
>
> 1. blk_new_open(), which already enabled the write cache
> 2. Some test cases that don't care about the setting
> 3. blockdev_init() for empty drives, where the cache mode is overridden
>    with the value from the options when a medium is inserted
>
> Therefore, this patch doesn't change the current behaviour. It will be
> convenient, however, for additional users of blk_new() (like block
> jobs) if the most sensible WCE setting is the default.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>

Berto