[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 25/27] tests: Use null-co:// instead of /dev/
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v5 25/27] tests: Use null-co:// instead of /dev/null |
Date: |
Wed, 25 May 2016 15:57:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17.05.2016 09:35, Fam Zheng wrote:
> With image locking, opening /dev/null can fail when multiple tests run
> in parallel (make -j2, for example). Use null-co:// as the null protocol
> doesn't do image locking.
>
> While it's arguable we could special-case /dev/null, /dev/zero,
> /dev/urandom etc in raw-posix driver, it is not really necessary because
> user can always specify lock-mode=off when it is appropriate. So let's
> write sensible testing code too.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/drive_del-test.c | 2 +-
> tests/nvme-test.c | 2 +-
> tests/usb-hcd-uhci-test.c | 2 +-
> tests/usb-hcd-xhci-test.c | 2 +-
> tests/virtio-blk-test.c | 2 +-
> tests/virtio-scsi-test.c | 4 ++--
> 6 files changed, 7 insertions(+), 7 deletions(-)
I prefer a plain driver=null-co instead of file=null-co://,format=raw,
but whatever floats your boat.
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 23/27] iotests: 087: Disable image lock in cases where file is shared, (continued)
- [Qemu-devel] [PATCH v5 23/27] iotests: 087: Disable image lock in cases where file is shared, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 22/27] qemu-iotests: 030: Disable image lock when checking test image, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 24/27] iotests: Disable image locking in 085, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 26/27] block: Turn on image locking by default, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 25/27] tests: Use null-co:// instead of /dev/null, Fam Zheng, 2016/05/17
- Re: [Qemu-devel] [PATCH v5 25/27] tests: Use null-co:// instead of /dev/null,
Max Reitz <=
- [Qemu-devel] [PATCH v5 27/27] qemu-iotests: Add test case 153 for image locking, Fam Zheng, 2016/05/17
- Re: [Qemu-devel] [PATCH v5 00/27] block: Lock images when opening, Richard W.M. Jones, 2016/05/24