[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/13] vmdk: Convert to bdrv_co_pwrite_zeroes()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 12/13] vmdk: Convert to bdrv_co_pwrite_zeroes() |
Date: |
Wed, 25 May 2016 16:23:27 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 25.05.2016 um 00:25 hat Eric Blake geschrieben:
> Another step on our continuing quest to switch to byte-based
> interfaces.
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> block/vmdk.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 8494d63..284d7a0 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -1704,15 +1704,14 @@ static int vmdk_write_compressed(BlockDriverState *bs,
> }
> }
>
> -static int coroutine_fn vmdk_co_write_zeroes(BlockDriverState *bs,
> - int64_t sector_num,
> - int nb_sectors,
> - BdrvRequestFlags flags)
> +static int coroutine_fn vmdk_co_pwrite_zeroes(BlockDriverState *bs,
> + int64_t offset,
> + int count,
> + BdrvRequestFlags flags)
> {
> int ret;
> BDRVVmdkState *s = bs->opaque;
> - uint64_t offset = sector_num * BDRV_SECTOR_SIZE;
> - uint64_t bytes = nb_sectors * BDRV_SECTOR_SIZE;
> + uint64_t bytes = count;
That's an unnecessary variable again. Whether you decide to change it or
not:
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH 00/13] Kill sector-based write_zeroes, Eric Blake, 2016/05/24
- [Qemu-devel] [PATCH 13/13] block: Kill bdrv_co_write_zeroes(), Eric Blake, 2016/05/24
- [Qemu-devel] [PATCH 05/13] iscsi: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/05/24
- [Qemu-devel] [PATCH 09/13] qed: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/05/24
- [Qemu-devel] [PATCH 12/13] vmdk: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/05/24
- Re: [Qemu-devel] [PATCH 12/13] vmdk: Convert to bdrv_co_pwrite_zeroes(),
Kevin Wolf <=
- [Qemu-devel] [PATCH 03/13] block: Add .bdrv_co_pwrite_zeroes(), Eric Blake, 2016/05/24
- [Qemu-devel] [PATCH 07/13] blkreplay: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/05/24
- [Qemu-devel] [PATCH 10/13] raw-posix: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/05/24
- [Qemu-devel] [PATCH 06/13] qcow2: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/05/24
- [Qemu-devel] [PATCH 11/13] raw_bsd: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/05/24