qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects
Date: Thu, 26 May 2016 12:51:23 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0


On 26/05/2016 12:47, Bharata B Rao wrote:
>>> > >          } else if (cpu->stop || cpu->stopped) {
>>> > > +            if (cpu->unplug) {
>> > 
>> > This "if" is unnecessary.  next_cpu is not used anymore after the
>> > "break", so the store is dead.
> next_cpu is a global here. Won't tcg_exec_all() continue with running the
> next_cpu when it is called the next time ?

You're right, sorry!

Thanks,

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]