[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 10/12] tcg/tci: Add support for fence

From: Pranith Kumar
Subject: Re: [Qemu-devel] [PATCH v2 10/12] tcg/tci: Add support for fence
Date: Fri, 27 May 2016 10:21:37 -0400

On Fri, May 27, 2016 at 10:20 AM, Sergey Fedorov <address@hidden> wrote:
>>>> +        case INDEX_op_fence:
>>>> +            smp_mb();
>>>> +            break;
>>>>          default:
>>>>              TODO();
>>>>              break;
>>> A bit of bike-shedding. While there's no common ISA term for "memory
>>> barrier" (also known as a "membar", "memory fence", etc.), we already
>>> refer to it as a "memory barrier" (or "mb") in include/qemu/atomic.h and
>>> docs/atomics.txt. Why don't be consistent and avoid introducing yet
>>> another term for the same thing?
>> Fair point. Do you think tcg_out_mb() is better then?
> Yes, if used together with 'INDEX_op_mb', of course.

OK. I'll make the change. Thanks for the feedback!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]