[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] Reveal 'to' parameter of 'vnc' option to us
Re: [Qemu-devel] [PATCH 0/2] Reveal 'to' parameter of 'vnc' option to user
Tue, 31 May 2016 14:59:23 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0
On 31/05/2016 09:03, Robert Ho wrote:
> I find that '-vnc' option actually has a parameter 'to', implicitly;
> while actually is there and can be used but not be public.
> Don't know why but this may probably confuse user, especially when used in
> some default situation implicitly.
> So shall I?
> 1. Add its description in QEMU manual info
> 2. Expilicitly print out when it's used with non-default value
I think patch 1 is okay.
For patch 2, I am not sure I see the point of printing the VNC options;
the VNC port is printed immediately after.
However, I think it is useful to print the VNC port whenever the user
specifies "-vnc to=XX". Perhaps you could move show_vnc_port (the
variable, the assignments and the "if (show_vnc_port)") from vl.c to