[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 2/2] add debian-bootstrap.docker target

From: Alex Bennée
Subject: Re: [Qemu-devel] [RFC PATCH 2/2] add debian-bootstrap.docker target
Date: Tue, 31 May 2016 16:27:18 +0100
User-agent: mu4e 0.9.17; emacs

Fam Zheng <address@hidden> writes:

> On Thu, 05/26 15:27, Alex Bennée wrote:
>> Together with some changes to the docker script you can now build an
>> arbitrary architecture of Debian using debootstrap. To achieve this I
>> introduce the concept of a HOST_CMD in the docker config file. While
>> copying the file into workspace the HOST_CMD is run in the docker build
>> context. This allows debootstrap to set up its first stage before the
>> container is built.
> Could you instead introduce the concept of $IMAGE.pre file (in this case
> debian-bootstrap.pre, aside debian-bootstrap.docker), and exec it in
> docker.py?  It would be much more flexible, and we we wouldn't need to inject 
> a
> custom directive to filter it out.

I'm ambivalent about that. To be honest this is a bit of a gap in
docker's image creation (or if there is a better more docker-y way of
doing things I couldn't find it). It does have the benefit of keeping
everything in one place.

We are copying the dockerfile to the build environment anyway so it
seemed natural to do the operation while copying across. How would
envison the .pre setup? A #! script we just exec inside the temp
directory we create?

> Fam

Alex Bennée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]