[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 00/11] Add param Error ** for msi_init()

From: Cao jin
Subject: Re: [Qemu-devel] [PATCH v6 00/11] Add param Error ** for msi_init()
Date: Wed, 1 Jun 2016 11:06:17 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0


On 05/24/2016 12:04 PM, Cao jin wrote:
v6 changelog:
1. make "assert ENOSPC" the 1st one in the series, and remove ENOSPC line
    of comments of msi_init(). also fix to other minor comments.
2. Because semantics changes, add hint message for devices who have msi/msix
    property, to help old machine user to know what should do
3. update pci_bridge_dev hehaviour, because it has non-msi variant, but it can
    never fall back to INTx before the patch. make it behaviour like others
4. mptsas: forget to assign s->msi_in_use before, now make it.

About test: Only compiled every patch.

cc: Gerd Hoffmann <address@hidden>
cc: John Snow <address@hidden>
cc: Dmitry Fleytman <address@hidden>
cc: Jason Wang <address@hidden>
cc: Michael S. Tsirkin <address@hidden>
cc: Hannes Reinecke <address@hidden>
cc: Paolo Bonzini <address@hidden>
cc: Alex Williamson <address@hidden>
cc: Markus Armbruster <address@hidden>
cc: Marcel Apfelbaum <address@hidden>

Cao jin (11):
   pci core: assert ENOSPC when add capability
   fix some coding style problems
   change pvscsi_init_msi() type to void
   megasas: Fix
   mptsas: change .realize function name
   usb xhci: change msi/msix property type
   intel-hda: change msi property type
   mptsas: change msi property type
   megasas: change msi/msix property type
   pci bridge dev: change msi property type
   pci: Convert msi_init() to Error and fix callers to check it

  hw/audio/intel-hda.c               | 23 ++++++++++++++----
  hw/ide/ich.c                       | 17 +++++++++-----
  hw/net/vmxnet3.c                   | 44 ++++++++++++++--------------------
  hw/pci-bridge/ioh3420.c            | 12 ++++++++--
  hw/pci-bridge/pci_bridge_dev.c     | 31 +++++++++++++++++-------
  hw/pci-bridge/xio3130_downstream.c | 11 +++++++--
  hw/pci-bridge/xio3130_upstream.c   |  8 ++++++-
  hw/pci/msi.c                       | 25 ++++++++++++++++++--
  hw/pci/pci.c                       |  6 ++---
  hw/scsi/megasas.c                  | 48 +++++++++++++++++++++-----------------
  hw/scsi/mptsas.c                   | 32 ++++++++++++++++++-------
  hw/scsi/mptsas.h                   |  3 ++-
  hw/scsi/vmw_pvscsi.c               | 10 ++++----
  hw/usb/hcd-xhci.c                  | 33 +++++++++++++++++++-------
  hw/vfio/pci.c                      |  7 ++++--
  include/hw/pci/msi.h               |  3 ++-
  16 files changed, 209 insertions(+), 104 deletions(-)

Yours Sincerely,

Cao jin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]