Re: [Qemu-devel] [PATCH 4/9] adding instructions encodings for LE and BE compilers.

[Michael Rolnik]

I disagree. it's non portable as long as you don't know what compiler you
are using.
if bitfields are not acceptable at all, I will regenerate my code.

thanks.

On Thu, Jun 2, 2016 at 9:32 AM, Richard Henderson <address@hidden> wrote:

> On 05/29/2016 06:23 PM, Michael Rolnik wrote:
>
>>     I am aware of bad portability of bit fields as compilers
>>     for LE and BE hosts lists bit fields in different order
>>     However they won't "parse" in target memory but a data prepared by me
>>
>
> What data prepared by you?  You're assigning to an int16_t and hoping that
> specific bit fields map to specific bits.  That's just non-portable.
>
> We don't want code that does that.  The fact that you had to replicate
> 1018 lines of code should have been a hint that you're doing it wrong.
>
> Take Peter's advice and use extract32.
>
>
> r~
>



-- 
Best Regards,
Michael Rolnik