[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/3] linux-user: netlink support

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2 0/3] linux-user: netlink support
Date: Thu, 2 Jun 2016 16:39:24 +0100

On 2 June 2016 at 16:34, Laurent Vivier <address@hidden> wrote:
> Le 24/05/2016 à 14:54, Riku Voipio a écrit :
>> dropped since the build failed on squeeze. I take the simplest fix is to
>> wrap all nl support #ifdef IFLA_PROTO_DOWN since that is the newest
>> define available.

> What do you think if instead I add a "--disable-netlink" (enabled by
> default) in configure?

I don't think we need a command line switch for this -- we should only
have those for cases where there's a reasonable user decision to
say "I don't want feature X (even if my host might support it)".
For this kind of thing we should just have a configure test for
"do the host headers support feature X" and unconditionally use it
if present. That's what we do for things like CONFIG_FIEMAP, for instance.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]