[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 13/22] block: Don't lock drive-backup target imag
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v6 13/22] block: Don't lock drive-backup target image in none mode |
Date: |
Fri, 3 Jun 2016 16:49:07 +0800 |
As a very special case, in sync=none mode, the source is the backing image of
the target, which will be RO opened again. This won't work with image locking
because the first open could be exclusive.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
blockdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 5acb286..fa8b50c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3256,6 +3256,11 @@ static void do_drive_backup(const char *device, const
char *target,
}
}
if (sync == MIRROR_SYNC_MODE_NONE) {
+ /* XXX: bs will be open second time as the backing file of target,
+ * disable image locking. Once block layer allows sharing backing BDS,
+ * change below to BDRV_O_NO_BACKING and assign it after bdrv_open().
+ **/
+ flags |= BDRV_O_NO_LOCK;
source = bs;
}
--
2.8.2
- [Qemu-devel] [PATCH v6 06/22] osdep: Introduce qemu_dup, (continued)
- [Qemu-devel] [PATCH v6 08/22] raw-posix: Add image locking support, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 12/22] qemu-nbd: Add "--no-lock/-L" option, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 10/22] qemu-img: Add "-L" option to sub commands, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 13/22] block: Don't lock drive-backup target image in none mode,
Fam Zheng <=
- [Qemu-devel] [PATCH v6 11/22] qemu-img: Update documentation of "-L" option, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 14/22] mirror: Disable image locking on target backing chain, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 17/22] qemu-iotests: 030: Disable image locking when checking test image, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 16/22] qemu-iotests: Wait for QEMU processes before checking image in 091, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 15/22] qemu-iotests: 046: Move version detection out from verify_io, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 18/22] iotests: 087: Disable image locking in cases where file is shared, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 19/22] iotests: Disable image locking in 085, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 20/22] tests: Use null-co:// instead of /dev/null, Fam Zheng, 2016/06/03