[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 00/28] Add qapi-to-JSON and clone visitors

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v4 00/28] Add qapi-to-JSON and clone visitors
Date: Fri, 03 Jun 2016 14:09:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Most patches are ready as is or with minor touch-ups.

I'd probably drop PATCH 01.  The file name collision no longer exists,
and moving files just to improve their names a bit doesn't seem worth
the bother.

There are memory leaks in PATCH 12 and 24 (see review of PATCH 24).

PATCH 13 needs more work than I'm comfortable to do on commit.  Mostly
missing comment updates, but also a crash bug.

On PATCH 21, I have minor interface design doubts.

The only difficult question is what to do about invalid UTF-8 strings
and non-finite numbers.  Patches before PATCH 29 show opinions, but a
decision isn't made until PATCH 29.  Good, because it leaves most of
this series not blocked by the debate on what we should do.

I guess I could take PATCH 02-12 now, and let you respin the rest.  But
perhaps its easier if you respin all of them.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]