[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/10] target-avr: updating translate.c to use i

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 09/10] target-avr: updating translate.c to use instructions translation
Date: Sat, 4 Jun 2016 20:33:30 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 06/02/2016 01:07 PM, Michael Rolnik wrote:
+uint32_t    get_opcode(
+                                    uint8_t const      *code,
+                                    unsigned            bitBase,
+                                    unsigned            bitSize)
+    return  *(uint16_t *)code;

Unused.  And what was this supposed to do?

+        /*  decode next instruction */
+        ctx.inst[1].cpc = ctx.inst[0].npc;
+        decode_opc(cpu, &ctx, &ctx.inst[1]);

Why are you decoding one instruction ahead?

While I can see that this might be keen for some of the skip-next instructions, I don't see that you're using that just now. So perhaps delay this until it's actually used?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]