[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/10] target-avr: adding instructions encodings

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 04/10] target-avr: adding instructions encodings
Date: Sun, 5 Jun 2016 09:08:28 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 06/04/2016 10:09 PM, Michael Rolnik wrote:
1. The code was generated. Every instruction has its own extractors. there are
several reasons
    1. I don't have to think and gather the instructions into the group.
    2. I don't have to remember what group an instruction is in
    3. there is no performance penalty.

Well, that's fine. But I think it would be more appropriate for us to review the generator and input file rather than the generated code.

You can write custom rules in target-avr/Makefile to handle this.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]