[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [kvm-unit-tests PATCH v2 01/10] lib: xstr: allow multip
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [kvm-unit-tests PATCH v2 01/10] lib: xstr: allow multiple args |
Date: |
Mon, 6 Jun 2016 14:12:39 +0200 |
User-agent: |
Mutt/1.5.23.1 (2014-03-12) |
On Mon, Jun 06, 2016 at 11:49:09AM +0100, Alex Bennée wrote:
>
> Andrew Jones <address@hidden> writes:
>
> > Signed-off-by: Andrew Jones <address@hidden>
> > ---
> > lib/libcflat.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/libcflat.h b/lib/libcflat.h
> > index 582e3fc60e287..e5e588c742763 100644
> > --- a/lib/libcflat.h
> > +++ b/lib/libcflat.h
> > @@ -27,8 +27,8 @@
> >
> > #define __unused __attribute__((__unused__))
> >
> > -#define xstr(s) xxstr(s)
> > -#define xxstr(s) #s
> > +#define xstr(s...) xxstr(s)
> > +#define xxstr(s...) #s
>
> OK my knowledge of stringinfication is still rusty despite having read
> the QEMU softmmu code. However:
>
> printf("Unknown subtest:" xstr(foo,ba) "\n");
>
> Yields:
>
> Unknown subtestfoo,ba
>
> Is that what you wanted? Or were you aiming for xstr(foo,ba) => fooba
The way I did it (which is like Linux) is what I wanted, see Linux's
version in include/linux/stringify.h. I can correct $SUBJECT to make
that more clear if you like.
Thanks,
drew
>
> As an aside I couldn't actually see xstr being called with multiple
> arguments in the source tree.
>
> >
> > #define __ALIGN_MASK(x, mask) (((x) + (mask)) & ~(mask))
> > #define __ALIGN(x, a) __ALIGN_MASK(x, (typeof(x))(a) - 1)
>
>
> --
> Alex Bennée
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to address@hidden
> More majordomo info at http://vger.kernel.org/majordomo-info.html
- [Qemu-devel] [kvm-unit-tests PATCH v2 00/10] arm/arm64: add gic framework, Andrew Jones, 2016/06/04
- [Qemu-devel] [kvm-unit-tests PATCH v2 02/10] arm64: fix get_"sysreg32" and make MPIDR 64bit, Andrew Jones, 2016/06/04
- [Qemu-devel] [kvm-unit-tests PATCH v2 05/10] arm/arm64: irq enable/disable, Andrew Jones, 2016/06/04
- [Qemu-devel] [kvm-unit-tests PATCH v2 06/10] arm/arm64: add initial gicv2 support, Andrew Jones, 2016/06/04
- [Qemu-devel] [kvm-unit-tests PATCH v2 03/10] arm/arm64: smp: support more than 8 cpus, Andrew Jones, 2016/06/04