[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [QEMU RFC PATCH v3 4/6] Migration: migrate QTAILQ

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [QEMU RFC PATCH v3 4/6] Migration: migrate QTAILQ
Date: Mon, 6 Jun 2016 15:47:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 02/06/2016 17:01, Sascha Silbe wrote:
>> > +    /* For fields which need customized handling, such as QTAILQ in 
>> > queue.h*/
>> > +    VMS_CSTM            = 0x8000,
> Can you describe (in the comment) how this customised handling is
> performed, please? I.e. describe what exactly happens if the flag is
> set, from the point of view of an API consumer.
> Also, why do you need this flag at all? The only change I can see is
> that you pass additional information to VMStateInfo.get() / .put(),
> using NULL if it's not set. Why don't you just always pass the
> additional information? If the additional information is not needed by
> get() / put() the parameter will be unused anyway.

Having the flag seemed like a good idea to me, because it gives a
specific meaning to the offset fields in the VMStateField.  On the other
hand, it's true that it's unused...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]