[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vnc: generalize "VNC server running on ..." mes
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] vnc: generalize "VNC server running on ..." message |
|
Date: |
Mon, 6 Jun 2016 16:08:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 06/06/2016 14:06, Daniel P. Berrange wrote:
>> > @@ -3838,6 +3834,10 @@ void vnc_display_open(const char *id, Error **errp)
>> > }
>> > }
>> >
>> > + if (show_vnc_port) {
>> > + vnc_display_print_local_addr(vs);
>> > + }
>> > +
>> > qapi_free_SocketAddress(saddr);
>> > qapi_free_SocketAddress(wsaddr);
>> > return;
> By calling this from vnc_display_open, you'll cause it to
> print to stdout, even when using QMP, because qmp_change_vnc_listen
> calls vnc_display_open.
Hmm, yes. Markus, what's the best thing to do? Some kind of
monitor_printf?
Thanks,
Paolo