qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 7/9] target-avr: adding instruction decoder


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v4 7/9] target-avr: adding instruction decoder
Date: Mon, 6 Jun 2016 15:06:18 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 06/06/2016 03:37 AM, Michael Rolnik wrote:
+void avr_decode(uint32_t pc, uint32_t *length, uint32_t code, 
translate_function_t *translate)
+{
+    uint32_t opcode  = extract32(code, 0, 16);
+
+    switch (opcode & 0x0000d000) {
+        case    0x00000000: {
+            uint32_t opcode  = extract32(code, 0, 16);
+            switch (opcode & 0x00002c00) {
+                case    0x00000000: {
+                    uint32_t opcode  = extract32(code, 0, 16);

I thought you said you fixed these shadowing declarations.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]