[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] blockdev: clean up error handling in do_open

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v3] blockdev: clean up error handling in do_open_tray
Date: Tue, 7 Jun 2016 12:16:36 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 06.06.2016 um 20:15 hat Colin Lord geschrieben:
> Returns negative error codes and accompanying error messages in cases where
> the device has no tray or the tray is locked and isn't forced open. This
> extra information should result in better flexibility in functions that
> call do_open_tray.
> Signed-off-by: Colin Lord <address@hidden>
> Suggested by: Markus Armbruster <address@hidden>

Thanks, updated the queued patch with this.

As a minor remark, I think that having Suggested-by first is more common
because it matches the chronological order: First someone suggested the
change, then someone did the patch, and then someone merges it (that's
my S-o-b that I add while applying the patch). For the same reason, I
generally add Reviewed-by tags after the author's, but before my own
maintainer S-o-b.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]