qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] Makefile: add dependency on scripts/make_de


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 2/3] Makefile: add dependency on scripts/make_device_config.sh
Date: Tue, 7 Jun 2016 12:59:11 +0100

On 7 June 2016 at 12:48, Paolo Bonzini <address@hidden> wrote:
> Make sure that config-devices.mak is rebuilt whenever
> there is a change in the scripts that generates it.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 9e0e1f8..72e0d74 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -117,7 +117,7 @@ endif
>
>  -include $(SUBDIR_DEVICES_MAK_DEP)
>
> -%/config-devices.mak: default-configs/%.mak
> +%/config-devices.mak: default-configs/%.mak 
> $(SRC_PATH)/scripts/make_device_config.sh
>         $(call quiet-command, \
>              $(SHELL) $(SRC_PATH)/scripts/make_device_config.sh $< 
> $*-config-devices.mak.d $@ > address@hidden, "  GEN   address@hidden")
>         $(call quiet-command, if test -f $@; then \
> --
> 1.8.3.1

Reviewed-by: Peter Maydell <address@hidden>

(In this case you have added it to the pattern rule...)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]