[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] docker: Don't use eval trick on Makefile

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] docker: Don't use eval trick on Makefile
Date: Tue, 7 Jun 2016 15:30:02 +0100

On 7 June 2016 at 15:00, Peter Maydell <address@hidden> wrote:
> On 7 June 2016 at 04:24, Fam Zheng <address@hidden> wrote:
>> On Mon, 06/06 12:53, Eduardo Habkost wrote:
>>> The eval trick for defining DOCKER_SRC_COPY doesn't do anything
>>> useful, as DOCKER_SRC_COPY is immediately expanded just after it
>>> is defined, and CUR_TIME is already defined using ":=". Simply
>>> define it using ":=" so it is evaluated only once.
>>> The eval trick was also triggering an weird error on Travis builds:
>>>   qemu/tests/docker/Makefile.include:34: *** unterminated variable 
>>> reference.  Stop.
>>> The issue is not easily reproducible (maybe it's a bug in some
>>> versions of Make), but it is avoided if removing the eval trick.

> Hi; I'd like to apply this direct to master, because one of my build
> test machines hits this error intermittently, and so without the fix
> I can't reliably process any other pull requests.

Now applied, thanks.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]