[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/31] iscsi: Use block size as minimum zero/discard
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 06/31] iscsi: Use block size as minimum zero/discard alignment |
Date: |
Wed, 8 Jun 2016 11:16:32 +0200 |
From: Eric Blake <address@hidden>
If hardware does not advertise a minimum zero/discard
alignment, we still want to guarantee that the block layer
will align requests to our blocks, rather than the arbitrary
512-byte BDRV sector size.
Signed-off-by: Eric Blake <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/iscsi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index e7d5f7b..94f9974 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1711,6 +1711,8 @@ static void iscsi_refresh_limits(BlockDriverState *bs,
Error **errp)
}
bs->bl.discard_alignment =
sector_limits_lun2qemu(iscsilun->bl.opt_unmap_gran, iscsilun);
+ } else {
+ bs->bl.discard_alignment = iscsilun->block_size >> BDRV_SECTOR_BITS;
}
if (iscsilun->bl.max_ws_len < 0xffffffff) {
@@ -1720,6 +1722,9 @@ static void iscsi_refresh_limits(BlockDriverState *bs,
Error **errp)
if (iscsilun->lbp.lbpws) {
bs->bl.write_zeroes_alignment =
sector_limits_lun2qemu(iscsilun->bl.opt_unmap_gran, iscsilun);
+ } else {
+ bs->bl.write_zeroes_alignment =
+ iscsilun->block_size >> BDRV_SECTOR_BITS;
}
bs->bl.opt_transfer_length =
sector_limits_lun2qemu(iscsilun->bl.opt_xfer_len, iscsilun);
--
1.8.3.1
- [Qemu-devel] [PULL 00/31] Block layer patches, Kevin Wolf, 2016/06/08
- [Qemu-devel] [PULL 06/31] iscsi: Use block size as minimum zero/discard alignment,
Kevin Wolf <=
- [Qemu-devel] [PULL 02/31] qcow2: simplify logic in qcow2_co_write_zeroes, Kevin Wolf, 2016/06/08
- [Qemu-devel] [PULL 07/31] block: Track write zero limits in bytes, Kevin Wolf, 2016/06/08
- [Qemu-devel] [PULL 08/31] block: Add .bdrv_co_pwrite_zeroes(), Kevin Wolf, 2016/06/08
- [Qemu-devel] [PULL 01/31] block: split write_zeroes always, Kevin Wolf, 2016/06/08
- [Qemu-devel] [PULL 03/31] qcow2: add tracepoints for qcow2_co_write_zeroes, Kevin Wolf, 2016/06/08
- [Qemu-devel] [PULL 10/31] iscsi: Convert to bdrv_co_pwrite_zeroes(), Kevin Wolf, 2016/06/08
- [Qemu-devel] [PULL 11/31] qcow2: Convert to bdrv_co_pwrite_zeroes(), Kevin Wolf, 2016/06/08
- [Qemu-devel] [PULL 05/31] qcow2: Catch more unaligned write_zero into zero cluster, Kevin Wolf, 2016/06/08
- [Qemu-devel] [PULL 17/31] vmdk: Convert to bdrv_co_pwrite_zeroes(), Kevin Wolf, 2016/06/08
- [Qemu-devel] [PULL 19/31] migration/block: Convert load to BlockBackend, Kevin Wolf, 2016/06/08