[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io

From: Denis V. Lunev
Subject: Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io
Date: Wed, 8 Jun 2016 14:31:02 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 06/08/2016 02:23 PM, Kevin Wolf wrote:
Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben:
From: Vladimir Sementsov-Ogievskiy <address@hidden>

Acquire aio context before run command, this is mandatory for unit tests.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Paolo Bonzini <address@hidden>
Looks right to me, but why "mandatory for unit tests"? Does this fix an
observable bug in unit tests? If so, we should be more specific in the
commit message.

But in fact, I would only expect it to make a difference for dataplane
and I don't think we have test cases that use both the 'qemu-io' HMP
command and dataplane.

we have failures in backup test, where dirty bitmap is protected with
aio_context_acquire. This test is not committed yet, but present in the
mail list.

As far as I know this command is used mostly for tests thus I have
written commit message this way. This change is separate and I think
definitely right.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]