[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Use $(..) instead of deprecated `..`

From: Maciej W. Rozycki
Subject: Re: [Qemu-devel] [PATCH] configure: Use $(..) instead of deprecated `..`
Date: Wed, 8 Jun 2016 14:46:16 +0100
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)

On Wed, 8 Jun 2016, Stefan Weil wrote:

> >  Unlike `..` the $(..) Bourne shell construct is not fully portable, some 
> > implementations do not recognise it.  Consequently this change potentially 
> > breaks building QEMU on some systems, possibly in a non-obvious way, as 
> > there's no explicit check for the presence this feature and a graceful 
> > failure path included with this patch or the other one AFAICT.  We may or 
> > may not care about those systems, but still this is a functional 
> > regression and therefore I think there has to be a good reason for 
> > introducing it.
> As the $() construct was already used in QEMU code before this commit
> (we had a mixture of both styles), I don't expect anything to break
> which was not broken before.

 Fair enough then.  Thanks for the explanation.  It would have made sense 
to mention it in the commit message though.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]