[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of o
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr |
Date: |
Thu, 9 Jun 2016 14:29:00 -0300 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, Jun 09, 2016 at 07:10:58PM +0200, Igor Mammedov wrote:
[...]
> +
> + if (local_err) {
> + error_propagate(errp, local_err);
> }
error_propagate() already ignores local_err==NULL so you don't
need to check it first.
I can change this while applying the patch, if you're OK.
Reviewed-by: Eduardo Habkost <address@hidden>
--
Eduardo
- [Qemu-devel] [PATCH v2 0/6] cpus: make "-cpu cpux, features" global properties, Igor Mammedov, 2016/06/09
- [Qemu-devel] [PATCH v2 5/6] arm: virt: parse cpu_model only once, Igor Mammedov, 2016/06/09
- [Qemu-devel] [PATCH v2 2/6] target-i386: print obsolete warnings if +-features are used, Igor Mammedov, 2016/06/09
- [Qemu-devel] [PATCH v2 6/6] pc: parse cpu features only once, Igor Mammedov, 2016/06/09
- [Qemu-devel] [PATCH v2 4/6] cpu: use CPUClass->parse_features() as convertor to global properties, Igor Mammedov, 2016/06/09