[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] migration: Don't use *_to_cpup() and cpu_to_
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] migration: Don't use *_to_cpup() and cpu_to_*w() |
|
Date: |
Fri, 10 Jun 2016 13:15:12 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/10/2016 10:09 AM, Peter Maydell wrote:
> The *_to_cpup() and cpu_to_*w() functions just compose a pointer
> dereference with a byteswap. Instead use ld*_p() and st*_p(),
> which handle potential pointer misalignment and avoid the need
> to cast the pointer.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Changes v1->v2: fix cpu_to_*w() uses too.
>
> The motivation here is that I'd like to get rid of _to_cpup()
> and cpu_to_*w() entirely: we don't have many places that use them.
> ---
> migration/migration.c | 12 ++++++------
> migration/savevm.c | 4 ++--
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature