[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 00/15] tb hash improvements

From: Richard Henderson
Subject: Re: [Qemu-devel] [PULL 00/15] tb hash improvements
Date: Sat, 11 Jun 2016 16:09:47 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 06/10/2016 09:41 AM, Peter Maydell wrote:
On 10 June 2016 at 17:34, Emilio G. Cota <address@hidden> wrote:
On Fri, Jun 10, 2016 at 16:33:10 +0100, Peter Maydell wrote:
Fails to build on ppc64be :-(

In file included from /home/pm215/qemu/include/qemu/thread.h:4:0,
                 from /home/pm215/qemu/include/block/aio.h:20,
                 from /home/pm215/qemu/include/block/block.h:4,
                 from /home/pm215/qemu/include/monitor/monitor.h:6,
                 from /home/pm215/qemu/trace/control.c:23:
/home/pm215/qemu/include/qemu/processor.h:24:35: error: expected
identifier or ‘(’ before string constant
                                   "or 2, 2, 2;" ::: "memory")

On Fri, Jun 10, 2016 at 16:57:19 +0100, Peter Maydell wrote:
Also fails trying to build a test on 32-bit:

/home/petmay01/qemu/tests/qht-bench.c: In function 'pr_params':
/home/petmay01/qemu/tests/qht-bench.c:270:5: error: format '%zu'
expects argument of type 'size_t', but argument 2 has type 'long
unsigned int' [-Werror=format=]
     printf(" lookup range:      %zu\n", lookup_range);

Can you please test again after applying the appended delta?

I will test.

For the PPC asm, is it not just wanting the "\n" between instructions?
Shouldn't be necessary to use two separate asm() lines...

It has a ; between instructions.  That's not the problem.

What it needs is a \ to continue the macro to the second line.

I've just finished a build on ppc64 with that one character fix.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]