[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/sh4/sh_pci.c: Use ldl_le_p() and stl_le_p()
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] hw/sh4/sh_pci.c: Use ldl_le_p() and stl_le_p() |
Date: |
Mon, 13 Jun 2016 08:55:22 +0200 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On 2016-06-10 17:10, Peter Maydell wrote:
> Use ldl_le_p() and stl_le_p() instead of le32_to_cpup() and
> cpu_to_le32w(); the former handle misaligned addresses and don't
> need casts, and the latter are deprecated.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/sh4/sh_pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c
> index e820a32..1747628 100644
> --- a/hw/sh4/sh_pci.c
> +++ b/hw/sh4/sh_pci.c
> @@ -55,7 +55,7 @@ static void sh_pci_reg_write (void *p, hwaddr addr,
> uint64_t val,
>
> switch(addr) {
> case 0 ... 0xfc:
> - cpu_to_le32w((uint32_t*)(pcic->dev->config + addr), val);
> + stl_le_p(pcic->dev->config + addr, val);
> break;
> case 0x1c0:
> pcic->par = val;
> @@ -85,7 +85,7 @@ static uint64_t sh_pci_reg_read (void *p, hwaddr addr,
>
> switch(addr) {
> case 0 ... 0xfc:
> - return le32_to_cpup((uint32_t*)(pcic->dev->config + addr));
> + return ldl_le_p(pcic->dev->config + addr);
> case 0x1c0:
> return pcic->par;
> case 0x1c4:
Thanks for the patch. I confirm it builds and works fine.
Acked-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net