[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] tests/test-qga leaks an unhelpfully named temp file

From: Peter Maydell
Subject: [Qemu-devel] tests/test-qga leaks an unhelpfully named temp file
Date: Mon, 13 Jun 2016 13:02:07 +0100

In tests/test-qga.c, this code from test_qga_config():

+    tmp = g_file_open_tmp(NULL, &conf, &error);

creates a file with the default template, which means it will be
something like "/tmp/.VQN0HY", and doesn't do anything to ensure
it is deleted when the test is over. This means that every time you
run make test another of these files gets created in /tmp/, and it's
tricky to figure out who the culprit is because there's no reference
to QEMU or test-qga in the filename.

Could somebody fix this to:
 (1) use a template name which can be usefully grepped for (and
  which includes 'qemu' in it somewhere)
 (2) unlink the file, preferably both on successful test completion
  and also if we exit early due to a test failure

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]