[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] nbd: simplify the nbd_request and nbd_reply str

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] nbd: simplify the nbd_request and nbd_reply structs
Date: Mon, 13 Jun 2016 06:27:13 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 06/13/2016 03:43 AM, Paolo Bonzini wrote:
> These structs are never used to represent the bytes that go over the
> network.  The big-endian network data is built into a uint8_t array
> in nbd_{receive,send}_{request,reply}.  Remove the unused magic field,
> reorder the struct to avoid holes, and remove the packed attribute.
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  include/block/nbd.h | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]