[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/3] generic-loader: Add a generic loader
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v7 2/3] generic-loader: Add a generic loader |
|
Date: |
Mon, 13 Jun 2016 19:05:08 +0100 |
On 13 June 2016 at 18:25, Alistair Francis <address@hidden> wrote:
> On Thu, Jun 9, 2016 at 10:50 AM, Peter Maydell <address@hidden> wrote:
>> On 25 May 2016 at 19:49, Alistair Francis <address@hidden> wrote:
>>> + uint16_t cpu_num;
>>
>> (Why 16 bits in particular?)
>
> No reason in particular. Do you think it should be something else?
Most other places that deal with cpu indexes use 'int'.
There doesn't seem any pressing reason to limit it to a
16 bit value here. (You want uint32_t for migration
purposes rather than just 'int' though.)
thanks
-- PMM