[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 15/15] mirror: follow AioContext change grace
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 15/15] mirror: follow AioContext change gracefully |
Date: |
Tue, 14 Jun 2016 14:09:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 13/06/2016 19:05, Stefan Hajnoczi wrote:
> index 80fd3c7..046e95c 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -331,6 +331,8 @@ static uint64_t coroutine_fn
> mirror_iteration(MirrorBlockJob *s)
> mirror_wait_for_io(s);
> }
>
> + block_job_pause_point(&s->common);
I/O can be in-flight here, so your description of the function is not
100% accurate. I suppose it's okay because s->waiting_for_io is false
at the pause points you specified?
I guess a comment that explains it will do; and apart from this detail,
the patches are really nice. Or maybe it's just that you scared with
that 00/15 in the cover letter. :->
Paolo
> cnt = bdrv_get_dirty_count(s->dirty_bitmap);
> /* s->common.offset contains the number of bytes already processed so
> * far, cnt is the number of dirty sectors remaining and
> @@ -781,18 +787,38 @@ static void mirror_complete(BlockJob *job, Error **errp)
> block_job_enter(&s->common);
> }
- [Qemu-devel] [PATCH v3 06/15] target-i386: Move user-mode exception actions out of user-exec.c, (continued)
- [Qemu-devel] [PATCH v3 06/15] target-i386: Move user-mode exception actions out of user-exec.c, Stefan Hajnoczi, 2016/06/13
- [Qemu-devel] [PATCH v3 08/15] ui: fix regression in printing VNC host/port on startup, Stefan Hajnoczi, 2016/06/13
- [Qemu-devel] [PATCH v3 07/15] vnc: drop unused depth arg for set_pixel_format, Stefan Hajnoczi, 2016/06/13
- [Qemu-devel] [PATCH v3 09/15] gtk: fix vte version check, Stefan Hajnoczi, 2016/06/13
- [Qemu-devel] [PATCH v3 10/15] ui/console-gl: Add support for big endian display surfaces, Stefan Hajnoczi, 2016/06/13
- [Qemu-devel] [PATCH v3 12/15] blockjob: move iostatus reset out of block_job_enter(), Stefan Hajnoczi, 2016/06/13
- [Qemu-devel] [PATCH v3 11/15] console: ignore ui_info updates which don't actually update something, Stefan Hajnoczi, 2016/06/13
- [Qemu-devel] [PATCH v3 13/15] blockjob: add pause points, Stefan Hajnoczi, 2016/06/13
- [Qemu-devel] [PATCH v3 14/15] blockjob: add AioContext attach/detach callbacks, Stefan Hajnoczi, 2016/06/13
- [Qemu-devel] [PATCH v3 15/15] mirror: follow AioContext change gracefully, Stefan Hajnoczi, 2016/06/13
- Re: [Qemu-devel] [PATCH v3 15/15] mirror: follow AioContext change gracefully,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v3 00/15] mirror: follow AioContext change gracefully, Stefan Hajnoczi, 2016/06/13
- Re: [Qemu-devel] [PATCH v3 00/15] mirror: follow AioContext change gracefully, Fam Zheng, 2016/06/14