[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors
Date: Tue, 14 Jun 2016 14:35:00 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> Rather than having two separate visitor callbacks with items
> already broken out, pass the actual QAPISchemaObjectType object
> to the visitor.  This lets the visitor access things like
> type.is_implicit() without needing another parameter, resolving
> a TODO from previous patches.
> For convenience and consistency, the 'name' and 'info' parameters
> are still provided, even though they are now redundant with
> 'typ.name' and 'typ.info'.
> Signed-off-by: Eric Blake <address@hidden>

We've seen this one before :)

The previous review is relevant:
Message-ID: <address@hidden>

Quote its recap of pros and cons:

* The existing interface

      def visit_object_type(self, name, info, base, members, variants):
      def visit_object_type_flat(self, name, info, members, variants):

  is explicit and narrow, but when you need more information, you have
  to add parameters or functions.

* The new interface

     def visit_object_type(self, name, info, typ):

  avoids that, but now its users can access everything.

End quote.  Let's see how this series profits from the patch, and
whether we want to change the other visit methods as well for

reply via email to

[Prev in Thread] Current Thread [Next in Thread]