[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 02/15] net: use Netdev instead of NetClientOp
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v7 02/15] net: use Netdev instead of NetClientOptions in client init |
Date: |
Tue, 14 Jun 2016 15:11:29 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> From: Kővágó, Zoltán <address@hidden>
First posted almost a year ago. I'm glad we're finally ready for this
work. Zoltán, I'm sorry it has taken us so long.
> This way we no longer need NetClientOptions and can convert Netdev
> into a flat union.
That's work enabled by this patch, not done by it. We won't actually
get rid of NetClientOptions, only confine it to legacy command line
support.
> Signed-off-by: Kővágó, Zoltán <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Message-Id: <address@hidden>
>
> [rework net_client_init1() to pass Netdev by copying from NetdevLegacy,
> rather than merging the two types; rebase to qapi changes]
> Signed-off-by: Eric Blake <address@hidden>
The patch is mostly mechanical: wherever we replace parameter
NetClientOptions *opts by Netdev *netdev, we replace opts by
netdev->opts, because netdev wraps opts:
struct Netdev {
char *id;
NetClientOptions *opts;
};
The interesting part is the change to net_client_init1(), which looks
sane.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v7 02/15] net: use Netdev instead of NetClientOptions in client init,
Markus Armbruster <=